Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

macos x86_64 nightly testing flake fix #4002

Merged
merged 7 commits into from
Sep 9, 2022
Merged

Conversation

Anton-4
Copy link
Collaborator

@Anton-4 Anton-4 commented Sep 9, 2022

No description provided.

@Anton-4 Anton-4 added macos Specific to macOS ci/cd Continuous Integration/Deployment labels Sep 9, 2022
Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com>
@Anton-4 Anton-4 changed the title macos x86_64 nightly testing fix macos x86_64 nightly testing flake fix Sep 9, 2022
@Anton-4
Copy link
Collaborator Author

Anton-4 commented Sep 9, 2022

All github hosted macos machines share the same IP and github does per-IP counting for rate limiting.
This is why some curl requests do not succeed.
See issue actions/runner-images#602

@Anton-4 Anton-4 marked this pull request as ready for review September 9, 2022 17:07
@Anton-4
Copy link
Collaborator Author

Anton-4 commented Sep 9, 2022

Adding our GITHUB_TOKEN to authenticate the request solved the issue.

@Anton-4 Anton-4 requested a review from ayazhafiz September 9, 2022 17:07
@ayazhafiz
Copy link
Member

All github hosted macos machines share the same IP and github does per-IP counting for rate limiting.

Wow! That's really surprising!

@ayazhafiz ayazhafiz merged commit 5b4b2c1 into main Sep 9, 2022
@ayazhafiz ayazhafiz deleted the macos_nightly_test_fix branch September 9, 2022 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci/cd Continuous Integration/Deployment macos Specific to macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants