Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Functions: don't display osascript call #14

Merged
merged 3 commits into from
Jul 4, 2021

Conversation

fredericrous
Copy link
Contributor

@fredericrous fredericrous commented Jul 3, 2021

I've been using this for quite few weeks now. What do you think?

I use it to split the terminal with one key, like so:

__fish_apple_touchbar_bind_key 7 '╂ split' 'osascript -e "tell application \"System Events\" to key code 2 using command down"' '-s'

https://github.com/fredericrous/dotfiles/blob/main/private_dot_config/private_fish/conf.d/touchbar.fish#L7

useful with something like:
__fish_apple_touchbar_bind_key 7 '╂ split' 'osascript -e "tell application \"System Events\" to key code 2 using command down"' '-s'
@fredericrous
Copy link
Contributor Author

fredericrous commented Jul 4, 2021

Note: I removed the PR for a sec because I thought not putting the -s would achieve the same result, but it does not

@fredericrous fredericrous deleted the patch-1 branch July 4, 2021 11:49
@fredericrous fredericrous restored the patch-1 branch July 4, 2021 11:52
@fredericrous fredericrous reopened this Jul 4, 2021
Use --quiet instead of - q to improve readability.
Refactor nested if-else statements using guard clauses to reduce code complexity.
@rodrigobdz rodrigobdz self-requested a review July 4, 2021 18:12
@rodrigobdz
Copy link
Owner

@fredericrous thanks for contributing! Looks good to me

@rodrigobdz rodrigobdz merged commit 25d968e into rodrigobdz:main Jul 4, 2021
@fredericrous fredericrous deleted the patch-1 branch July 5, 2021 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants