Remove unnecessary basename and awk call
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
changed the title
basename and awk call
|
@kidonng Thanks for your contribution! LGTM. I'm all in for performance improvements |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to call
basenameif it is a fixed string. Plus it will slow down shell startup time a bit.Also replaced
awkcall withstring matchto reduce external dependencies. This builtin dates back to pre-3.0 version of Fish so compatibility should not be an issue.I also threw in a change that I don't feel like making a separate PR (but I'd like to if requested): replace
exitinreturninfish-apple-touchbarfunction. Therefore innocent scripts that call this function in non-interactive sessions won't exit accidentally.