Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace URIParser with URIs #56

Closed
jmkuhn opened this issue Apr 22, 2021 · 1 comment · Fixed by #57
Closed

Replace URIParser with URIs #56

jmkuhn opened this issue Apr 22, 2021 · 1 comment · Fixed by #57

Comments

@jmkuhn
Copy link
Contributor

jmkuhn commented Apr 22, 2021

The README for URIParser indicates that it is deprecated in favor of URIs. Should we change the dependency for this package? This would be a breaking change so if we are going to make the change it should be before tagging 1.0. I could submit a PR if you agree that this should be done.

@rofinn
Copy link
Owner

rofinn commented Apr 22, 2021

Yes, a PR would be appreciated :) Scanning the docs it looks pretty similar, so updating the code here shouldn't be too difficult. Since we support 3rd party packages like that with Requires.jl we could probably support both package for a deprecation cycle and throw a depwarn when loading the URIParser glue code.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants