Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate URIParser; use URIs #57

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Deprecate URIParser; use URIs #57

merged 2 commits into from
Apr 23, 2021

Conversation

jmkuhn
Copy link
Contributor

@jmkuhn jmkuhn commented Apr 22, 2021

I'm not sure if this is the best way to do the depwarn. Let me know if you have suggestions for changes. Fixes #56

Project.toml Outdated Show resolved Hide resolved
test/test_uri.jl Show resolved Hide resolved
src/uriparser.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #57 (aa8e582) into master (2ad4e04) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines           69        83   +14     
=========================================
+ Hits            69        83   +14     
Impacted Files Coverage Δ
src/FilePaths.jl 100.00% <100.00%> (ø)
src/uriparser.jl 100.00% <100.00%> (ø)
src/uris.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad4e04...aa8e582. Read the comment docs.

Copy link
Owner

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, LGTM!

@rofinn rofinn merged commit 76df5f7 into rofinn:master Apr 23, 2021
@jmkuhn jmkuhn deleted the uri branch April 23, 2021 03:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace URIParser with URIs
2 participants