Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove glob mention #23

Merged
merged 1 commit into from
Feb 28, 2018
Merged

remove glob mention #23

merged 1 commit into from
Feb 28, 2018

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Feb 28, 2018

:,(

Just a tiny drive-by update. As author of Glob.jl, any comment on why the feature was dropped (#16)?

@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #23   +/-   ##
======================================
  Coverage    82.2%   82.2%           
======================================
  Files           8       8           
  Lines         399     399           
======================================
  Hits          328     328           
  Misses         71      71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a480e3c...ae9eb9b. Read the comment docs.

@rofinn
Copy link
Owner

rofinn commented Feb 28, 2018

Thanks. I liked having Glob.jl included for a lot of adhoc work, but I wanted to focus on the core functionality that might be a candidate for the stdlib. This meant dropping all of the nice-to-have dependencies, but I might make a FilePathExt.jl package that handles interactions with other packages via Requires.jl.

Related Issue: #18

@rofinn rofinn merged commit da658d3 into rofinn:master Feb 28, 2018
@vtjnash vtjnash deleted the patch-1 branch March 1, 2018 00:08
@vtjnash
Copy link
Contributor Author

vtjnash commented Mar 1, 2018

Makes sense. Though if this ends up moving into stdlib, I would pick up that integration code into Glob.jl instead :) I agree that it definitely is a prime example of the Requires.jl use case.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants