-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make signature support IDA/x64Dbg style #407
Conversation
LGTM, what platforms have you tested this on? |
I only tested on Windows. but I also tried to compile with GCC 13.2.1 and Clang 17.0.6 on my Arch WSL, while GCC ccompiled successfully without any error, clang required to remove |
Just took a look at why the build failed on linux, it turned out |
Tested on Linux using latest build artifact ✅ |
See discussion for more info.
TLDR: Make developers' life easier so they don't have to convert their signatures(
48 8B ?
) to code style(\x48\x8B\x2A
) every time when they make a signatureWhat's changed
48 8B ? ? ? ? ?
)std::views::split
)FindSignature
now usesstd::find
andstd::equal
for better readability