Fix Object.Set with an empty key string #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
force-pushed
the
fix-obj-set-empty-key
branch
from
46eeca7 to
f2c6b8a
Compare
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 95.87% 95.86% -0.02%
==========================================
Files 17 17
Lines 582 580 -2
==========================================
- Hits 558 556 -2
Misses 15 15
Partials 9 9
Continue to review full report at Codecov.
|
genevieve
approved these changes
Jan 12, 2022
ajvpot
referenced
this pull request
in ajvpot/lockfileparsergo
Jan 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rogchap.com/v8go](https://github.com/rogchap/v8go) | require | minor | `v0.7.0` -> `v0.8.0` | --- ### Release Notes <details> <summary>rogchap/v8go</summary> ### [`v0.8.0`](https://github.com/rogchap/v8go/releases/tag/v0.8.0) [Compare Source](https://github.com/rogchap/v8go/compare/v0.7.0...v0.8.0) Full changelog ⇒ [v0.8.0](https://github.com/rogchap/v8go/blob/master/CHANGELOG.md#v080---2023-01-19) #### What's Changed - Allocate profile node children array using count by [@​genevieve](https://github.com/genevieve) in [https://github.com/rogchap/v8go/pull/256](https://github.com/rogchap/v8go/pull/256) - Build v8 for linux_arm64 by [@​epk](https://github.com/epk) in [https://github.com/rogchap/v8go/pull/223](https://github.com/rogchap/v8go/pull/223) - CHANGELOG: Highlight the subtlety of the Function Call breaking change by [@​dylanahsmith](https://github.com/dylanahsmith) in [https://github.com/rogchap/v8go/pull/259](https://github.com/rogchap/v8go/pull/259) - change -fpic to -fPIC in cgo.go by [@​iwind](https://github.com/iwind) in [https://github.com/rogchap/v8go/pull/263](https://github.com/rogchap/v8go/pull/263) - Remove unnecessary nested Locker and Isolate::Scope use by [@​dylanahsmith](https://github.com/dylanahsmith) in [https://github.com/rogchap/v8go/pull/275](https://github.com/rogchap/v8go/pull/275) - Upgrade V8 binaries for 9.7.106.18 version by [@​github-actions](https://github.com/github-actions) in [https://github.com/rogchap/v8go/pull/264](https://github.com/rogchap/v8go/pull/264) - Use length to ensure null chars do not cause early termination of C string copies/reads by [@​genevieve](https://github.com/genevieve) in [https://github.com/rogchap/v8go/pull/272](https://github.com/rogchap/v8go/pull/272) - Fix Object.Set with an empty key string by [@​dylanahsmith](https://github.com/dylanahsmith) in [https://github.com/rogchap/v8go/pull/276](https://github.com/rogchap/v8go/pull/276) - Upgrade V8 binaries for 9.7.106.19 version by [@​github-actions](https://github.com/github-actions) in [https://github.com/rogchap/v8go/pull/278](https://github.com/rogchap/v8go/pull/278) - Fix typo in promise.go by [@​lukasmalkmus](https://github.com/lukasmalkmus) in [https://github.com/rogchap/v8go/pull/310](https://github.com/rogchap/v8go/pull/310) - Updating context documentation by [@​ryanmurakami](https://github.com/ryanmurakami) in [https://github.com/rogchap/v8go/pull/335](https://github.com/rogchap/v8go/pull/335) - Add additional CPUProfile values by [@​ryanmurakami](https://github.com/ryanmurakami) in [https://github.com/rogchap/v8go/pull/341](https://github.com/rogchap/v8go/pull/341) - v8.Value becomes manually releaseable by [@​fizx](https://github.com/fizx) in [https://github.com/rogchap/v8go/pull/361](https://github.com/rogchap/v8go/pull/361) #### New Contributors - [@​iwind](https://github.com/iwind) made their first contribution in [https://github.com/rogchap/v8go/pull/263](https://github.com/rogchap/v8go/pull/263) - [@​lukasmalkmus](https://github.com/lukasmalkmus) made their first contribution in [https://github.com/rogchap/v8go/pull/310](https://github.com/rogchap/v8go/pull/310) - [@​ryanmurakami](https://github.com/ryanmurakami) made their first contribution in [https://github.com/rogchap/v8go/pull/335](https://github.com/rogchap/v8go/pull/335) - [@​fizx](https://github.com/fizx) made their first contribution in [https://github.com/rogchap/v8go/pull/361](https://github.com/rogchap/v8go/pull/361) **Full Changelog**: rogchap/v8go@v0.7.0...v0.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ajvpot/lockfileparsergo). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuNCIsInVwZGF0ZWRJblZlciI6IjM0LjEwNS40In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
wowngasb
added a commit
to wowngasb/v8go
that referenced
this pull request
Jan 19, 2024
](https://renovatebot.com){kind=link}
commit cee5f84 Author: Jonathan Geddes <geddes.jonathan@gmail.com> Date: Mon Apr 10 10:09:13 2023 -0600 shared array buffers (rogchap#378) * Initial support for SharedArrayBuffer commit 0e40e6e Author: Randy Goodman <mullan17@gmail.com> Date: Mon Mar 20 19:27:55 2023 -0400 v0.9.0 (rogchap#376) commit be4ff5e Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 21 07:17:39 2023 +1100 Upgrade V8 binaries for 11.1.277.13 version (rogchap#373) commit 02e1763 Author: Jacques Nadeau <jacquesnadeau@gmail.com> Date: Mon Jan 30 06:51:45 2023 -0800 Upgrade V8 binaries for 10.9.194.9 version **working** (rogchap#363) * Upgrade V8 binaries for 10.9.194.9 version * Fixes to support newest stable v8. - Update github workflow to use go 18 & 19 - Update github workflow to use macos-latest - Update github build workflow to use ubuntu 22.04 - Add gitignore for jetbrains and .gclient_previous files - Switch cgo build to C++17 and enable sandbox at build time - Update test with update to date error message - Remove no longer supported build flag. - Move initialization to v8go.go and include flag set to avoid flag freezing - Reorder initialization so allocator is initialized after v8 (required by latest v8) * Update V8 static library for macos-11 x86_64 * Update V8 static library for ubuntu-22.04 x86_64 * Update V8 static library for macos-11 arm64 * Update V8 static library for ubuntu-22.04 arm64 * Update changelog and remove no-longer valid comment --------- Co-authored-by: jacques-n <jacques-n@users.noreply.github.com> commit 7d843f1 Author: Kyle Maxwell <kyle@kylemaxwell.com> Date: Thu Jan 19 13:17:30 2023 -0800 v8.Value becomes manually releaseable (rogchap#361) * values are manually releaseable Co-authored-by: Kyle Maxwell <kyle.maxwell@reddit.com> commit 1f00b50 Author: Ryan H. Lewis <ryan@ryanlewis.dev> Date: Wed Nov 2 14:15:10 2022 -0600 adding additional profile values (rogchap#341) commit fc8b9f1 Author: Ryan H. Lewis <ryan@ryanlewis.dev> Date: Mon Aug 8 16:10:42 2022 -0600 updating context documentation (rogchap#335) Co-authored-by: Ryan H Lewis <ryan.lewis@reddit.com> commit da7f43c Author: Lukas Malkmus <lukasmalkmus@users.noreply.github.com> Date: Wed Apr 13 16:20:09 2022 +0200 Fix typo in promise.go (rogchap#310) Literally just fixing a typo in `promise.go` that I discovered while strolling through the code. commit db78170 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 9 14:29:03 2022 -0800 Upgrade V8 binaries for 9.7.106.19 version (rogchap#278) * Upgrade V8 binaries for 9.7.106.19 version * Update V8 static library for ubuntu-18.04 x86_64 (rogchap#292) Co-authored-by: genevieve <genevieve@users.noreply.github.com> * Update V8 static library for ubuntu-18.04 arm64 (rogchap#293) Co-authored-by: genevieve <genevieve@users.noreply.github.com> * Update V8 static library for macos-11 x86_64 (rogchap#294) Co-authored-by: genevieve <genevieve@users.noreply.github.com> * Update V8 static library for macos-11 arm64 (rogchap#295) Co-authored-by: genevieve <genevieve@users.noreply.github.com> Co-authored-by: dylanahsmith <dylanahsmith@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: genevieve <genevieve@users.noreply.github.com> commit 5e91d3d Author: Dylan Thacker-Smith <dylan.smith@shopify.com> Date: Wed Jan 12 17:06:50 2022 -0500 Fix Object.Set with an empty key string (rogchap#276) commit 1d433f7 Author: Genevieve <genevieve.lesperance@shopify.com> Date: Wed Jan 12 10:41:04 2022 -0800 Use length to ensure null chars do not cause early termination of C string copies/reads (rogchap#272) * Intro test case for null terminator string * unexpected result: expected ss, got sx00s * Fix the assertion, add Unicode symbols * Pass go string length into v8::String::New to ensure it does not cut off at null chars * Reuse the existing RtnString type * Formatting * Update value_test.go Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com> * Table tests for NewValue * Use std::string constructor in CopyString(Utf8Value) to keep whole string * Update changelog Co-authored-by: Genevieve L'Esperance <glesperance@doximity.com> Co-authored-by: Maxim Shirshin <maxim.shirshin@shopify.com> Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com> commit cb8779b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 12 07:51:03 2022 -0800 Upgrade V8 binaries for 9.7.106.18 version (rogchap#264) Co-authored-by: dylanahsmith <dylanahsmith@users.noreply.github.com> Co-authored-by: Genevieve <genevieve.lesperance@shopify.com> commit c0dbfd3 Author: Dylan Thacker-Smith <dylan.smith@shopify.com> Date: Wed Jan 12 09:58:36 2022 -0500 Remove unnecessary nested Locker and Isolate::Scope use (rogchap#275) * Remove unnecessary nested Locker and Isolate::Scope use * Make ExceptionError static, since it isn't used outside that file commit ede7cee Author: Liu Xiangchao <iwind.liu@gmail.com> Date: Fri Jan 7 01:33:29 2022 +0800 modify -fpic to -fPIC (rogchap#263) commit a0417ad Author: Dylan Thacker-Smith <dylan.smith@shopify.com> Date: Wed Dec 22 15:48:45 2021 -0500 CHANGELOG: Highlight the subtlety of the Function Call breaking change (rogchap#259) commit 943fcf9 Author: Aditya Sharma <git@adi.run> Date: Wed Dec 22 09:30:54 2021 -0800 Build v8 for linux_arm64 (rogchap#223) * Build v8 for linux_arm64 * Update V8 static library for ubuntu-18.04 arm64 Co-authored-by: epk <epk@users.noreply.github.com> commit e635d48 Author: Genevieve <genevieve.lesperance@shopify.com> Date: Mon Dec 13 09:28:33 2021 -0800 Allocate children array with count (rogchap#256) commit 6e4af34 Author: Roger Chapman <rogchap@gmail.com> Date: Thu Dec 9 10:29:56 2021 +1100 v0.7.0 commit 762c7a8 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Dec 8 15:22:43 2021 -0800 Upgrade V8 binaries for 9.6.180.12 version (rogchap#231) * Upgrade V8 binaries for 9.6.180.12 version * Add -ldl flag to linux build to fix missing dlsym errors * Update V8 static library for macos-11 x86_64 (rogchap#249) Co-authored-by: genevieve <genevieve@users.noreply.github.com> * Update V8 static library for ubuntu-18.04 x86_64 (rogchap#250) Co-authored-by: genevieve <genevieve@users.noreply.github.com> * Update V8 static library for macos-11 arm64 (rogchap#251) Co-authored-by: genevieve <genevieve@users.noreply.github.com> * Update changelog Co-authored-by: dylanahsmith <dylanahsmith@users.noreply.github.com> Co-authored-by: Genevieve L'Esperance <genevieve.lesperance@shopify.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: genevieve <genevieve@users.noreply.github.com> commit a92639e Author: Genevieve <genevieve.lesperance@shopify.com> Date: Tue Nov 30 12:59:03 2021 -0800 Enable intl support and store data in v8 binary (rogchap#242) * Enable intl support and store data in v8 binary * Update V8 static library for ubuntu-18.04 x86_64 * Update V8 static library for macos-11 arm64 * Update changelog Co-authored-by: genevieve <genevieve@users.noreply.github.com> commit f55271d Author: Genevieve <genevieve.lesperance@shopify.com> Date: Mon Nov 22 14:50:43 2021 -0800 Remove Windows support (rogchap#234) * Remove Windows binary support * Update CHANGELOG.md Co-authored-by: Oliver Fuerst <87430407+ofuerst@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com> * Update windows section * Update README.md Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com> * Update README.md Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com> * Remove windows fossa step * Remove deps/windows_x86_64 Co-authored-by: Oliver Fuerst <87430407+ofuerst@users.noreply.github.com> Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com> Co-authored-by: Roger Chapman <rogchap@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262