Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implemented roPath component and fixed Interpreter Comparisons #50

Merged
merged 8 commits into from
Apr 1, 2024

Conversation

lvcabral
Copy link
Collaborator

@lvcabral lvcabral commented Mar 30, 2024

Implemented on this PR:

  • Added component roPath and unit tests
  • Fixed Interpreter comparison logic (in VisitBinary) to match Roku behavior, throw error with Type Mismatch
  • Fixed Interpreter AND and OR to properly compare Boolean and Numbers
  • Added --no-color option to CLI
  • Fixed unit tests to not fail when running on terminal that support colors.

This PR closes #12

@lvcabral lvcabral requested a review from TwitchBronBron March 30, 2024 21:38
@lvcabral lvcabral changed the title Implemented roPath component Implemented roPath component and fixed Interpreter Comparisons Mar 31, 2024
@lvcabral lvcabral merged commit ac1cd3e into master Apr 1, 2024
3 checks passed
@lvcabral lvcabral deleted the implement-roPath branch April 1, 2024 20:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing roPath
2 participants