Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Should floats also be treated as ALLOWED_CIRCULAR_REFERENCE_TYPES? #286

Closed
ajtran opened this issue Sep 7, 2018 · 0 comments
Closed

Should floats also be treated as ALLOWED_CIRCULAR_REFERENCE_TYPES? #286

ajtran opened this issue Sep 7, 2018 · 0 comments
Labels
enhancement

Comments

@ajtran
Copy link

ajtran commented Sep 7, 2018 •
edited by jessewgibbs
Loading

internal:

pyrollbar/rollbar/lib/transforms/__init__.py

Line 95 in ae70c1a

return do_transform('number', o, key=key)

@rivkahstandig3636 rivkahstandig3636 added this to the v0.14.5 milestone Sep 13, 2018
@jessewgibbs jessewgibbs removed this from the v0.14.5 milestone Oct 10, 2018
rokob added a commit that referenced this issue Oct 22, 2018
@rokob
Allow floats as circular references
f939723 
Fixes #286

Number types are okay if we see them multiple times, currently we only
treat integers this way but floats should also be allowed.
@rokob rokob mentioned this issue Oct 22, 2018
Merged
rokob added a commit that referenced this issue Oct 25, 2018
@rokob
Allow floats as circular references (#291)
0edfc4c 
Fixes #286

Number types are okay if we see them multiple times, currently we only
treat integers this way but floats should also be allowed.
@ezra-agathos ezra-agathos mentioned this issue Jan 27, 2022
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jessewgibbs @ajtran @rivkahstandig3636