Add configuration for custom person methods and use them. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation assumed a lot about the model, and in our case was unworkable since we already had a "current_user" helper. This adds configuration options to allow any user method, and furthermore any methods on that user model, to construct the person hash sent to Ratchet.
Also fix exception that happened when user was nil after trying to find it.
|
Fixed some bugs and tested this out in our application—all is working well now! Thanks. We'll give this a shot. |
brianr
pushed a commit
that referenced
this pull request
Nov 7, 2012
- default to `current_user` instead of `current_member` - make the `id` method configurable as well - rescue errors calling id/username/email on the returned person object - update README and add sample code to initializer template
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assumed a lot about the model, and in our case was unworkable since we already had a "current_user" helper. This adds configuration options to allow any user method, and furthermore any methods on that user model, to construct the person hash sent to Ratchet.