Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Removed the Config::getAllowedCircularReferenceTypes() method #603

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Removed the Config::getAllowedCircularReferenceTypes() method #603

merged 1 commit into from
Feb 22, 2023

Conversation

danielmorell
Copy link
Collaborator

@danielmorell danielmorell commented Feb 20, 2023 •
edited
Loading

Description of the change

In #417 some updates were made to how we handle circular references. However, a method that access a non-existent private property was accidentally left behind and was included in the final commit.

This PR simply removes it. I would not consider removing this public method a breaking change since calling it would throw an exception.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Related to issue #416 and PR #417.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell
Removed the Config::getAllowedCircularReferenceTypes() method that wa…
da7e901 
…s accidentally included in the final commit in #417
@danielmorell danielmorell added Type: Bug Fix a component so that its behavior aligns with its documentation. Rank: 4 - Low Tackle when there are no Critical, Major, or Minor requests. labels Feb 20, 2023
waltjones
waltjones approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 5c9b10b into master Feb 22, 2023
@danielmorell danielmorell deleted the removed/retained-unused-method branch February 22, 2023 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@waltjones waltjones waltjones approved these changes

@cyrusradfar cyrusradfar Awaiting requested review from cyrusradfar

Assignees
No one assigned
Labels
Rank: 4 - Low Tackle when there are no Critical, Major, or Minor requests. Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmorell @waltjones