This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
update rollup #141
Merged
update rollup #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have opened an issue with rollup to investigate this further as it seems you have stumbled across a bug here: rollup/rollup#1992 |
|
I just cloned this and linked in the current build of Rollup and it is definitely working for me with that test. |
|
Ah, spoke too soon... looking into it :) |
lukastaegert
suggested changes
Feb 25, 2018
test/test.js
Outdated
| @@ -369,7 +369,7 @@ describe( 'rollup-plugin-node-resolve', function () { | |||
| }) | |||
| ] | |||
| }).then( bundle => { | |||
| assert.deepEqual( bundle.imports.sort(), [] ); | |||
| assert.equal( bundle.modules.length, 2 ); | |||
There was a problem hiding this comment.
The latest release of rollup should fix these test regressions.
|
I reverted the test changes. |
lukastaegert
approved these changes
Feb 26, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #140
Not sure why the test change was necessary, but the new assertion tests the same thing.