Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert CustomPluginOptions to be an interface #5850

Conversation

sapphi-red
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

#5591 changed CustomPluginOptions type to be an Record, but that made it impossible to extend this type by declaration merging.
This PR reverts that change.

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 6:00am

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (b4cb7cc) to head (0523222).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5850   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         269      269           
  Lines        8545     8545           
  Branches     1467     1467           
=======================================
  Hits         8421     8421           
  Misses         92       92           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this makes a difference, but sure.

@lukastaegert lukastaegert added this pull request to the merge queue Feb 24, 2025
Merged via the queue into rollup:master with commit 31a8892 Feb 24, 2025
40 checks passed
Copy link

github-actions bot commented Mar 1, 2025

This PR has been released as part of rollup@4.34.9. You can test it via npm install rollup.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants