Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Windows support #79

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Windows support #79

merged 1 commit into from
Feb 4, 2025

Conversation

mhss1
Copy link
Contributor

@mhss1 mhss1 commented Feb 4, 2025

  • Fixed "source entry is not a Kotlin file" error when building on Windows
  • Fixed TitleBar overlaps with the control buttons and not showing correctly on Windows (images below)
  • Added Windows distribution configuration in build.gradle

"Build & Disassemble" was fixed by using File.pathSeparator instead of : and wrapping the classpath with qoutes.
"Run" was also fixed by using File.pathSeparator in the buildJavaCommand function

Title bar before
Screenshot 2025-02-02 202508
After
Screenshot 2025-02-04 104612

I wasn't sure who to include building the exe in the release.yml so I didn't edit it

@romainguy
Copy link
Owner

Thanks, much appreciated!

@romainguy romainguy merged commit b2ff460 into romainguy:main Feb 4, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants