[RF] Fix memory leak of ConcatFileName return value in RooWorkspace #18730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a memory leak of the `TSystem::ConcatFileName()` return value in RooWorkspace, and also refactor the code to avoid repetition. Thanks a lot to @ferdymercury for noticing this!
guitargeek
force-pushed
the
workspace_memleak
branch
from
bc4454c to
b4b9226
Compare
ferdymercury
approved these changes
May 15, 2025
Test Results 19 files 19 suites 3d 10h 49m 20s ⏱️ Results for commit b4b9226. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
May 16, 2025
silverweed
approved these changes
May 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a memory leak of the
TSystem::ConcatFileName()return value in RooWorkspace, and also refactor the code to avoid repetition.Thanks a lot to @ferdymercury for noticing this!
#18726 (comment)