Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

🐛 If WC tries to load existing parent template, still apply our l… #28

Merged
merged 1 commit into from
Oct 27, 2021
Merged

🐛 If WC tries to load existing parent template, still apply our l… #28

merged 1 commit into from
Oct 27, 2021

Conversation

kingkero
Copy link
Contributor

fixes #27

Is the === -1 an oversight? strpos will never return -1, only false and ints >= 0.

@thutter
Copy link

thutter commented Oct 22, 2021

Nice catch. I had a smiliar issue

@kingkero
Copy link
Contributor Author

ping @knowler

knowler
knowler approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@knowler knowler merged commit f4e790b into roots:master Oct 27, 2021
@kingkero kingkero deleted the feature/load-templates-with-parent branch October 28, 2021 10:33
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@knowler knowler knowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When sage is child theme and parent has templates, sage's templates are never loaded
3 participants
@kingkero @thutter @knowler