Add npm-run-all #2173
Merged
Add npm-run-all #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us run related scripts together pretty easily since we can use glob patterns (e.g. `lint:*` — `**` is supported too). You can either run scripts sequentially with `run-s` or in parallel with `run-p`. See: https://github.com/mysticatea/npm-run-all
This way lint issues for the scripts doesn’t block the styles from being linted.
knowler
force-pushed
the
sage-10-add-npm-run-all
branch
from
2a40bb8 to
51b7d5d
Compare
|
It could also be helpful to break up the |
* Break up `build:production`
* Refine `start` script to call `build` but using `--watch`
* Since the base command is the same, this makes it easier to
maintain.
* Use run-s for `test` script for consistency.
The only thing that differs between `build` and `build:production` is the Node environment variable. We can use `run-s build:mix` preceeded by the correspinding environment setting.
We need to pass `--watch` to the `build:mix` not `build`. Also, this means we need to set the Node environment beforehand since `build:mix` doesn’t have that.
`dist` needs to exist for HMR to work since it looks for `dist/hot`. This means we should probably build once before starting HMR. This also renames `build:mix` to just `mix` to keep a consistent naming scheme.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us run related scripts together pretty easily since we can use glob patterns (e.g.
lint:*—**is supported too). You can either run scripts sequentially withrun-sor in parallel withrun-p.See: https://github.com/mysticatea/npm-run-all