Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Continued Sage 10 cleanup #2174

Merged
merged 2 commits into from
May 3, 2019
Merged

Continued Sage 10 cleanup #2174

merged 2 commits into from
May 3, 2019

Conversation

Log1x
Copy link
Member

@Log1x Log1x commented May 3, 2019

Changelog

Enhancements

  • Add name configuration to config/app.php (defaults to theme name).
  • Move default cache location to storage/.
  • Add a ServiceProvider stub.
  • Add missing trailing commas to configs.
  • Remove/revert automatic Blade cache removal action as it is no longer necessary.
  • Clean up .gitignore.
  • Clean up JavaScript docblocks.
  • Remove home.js example leaving about.js to give an example of camelCase.
  • Remove leftover Sage 9 information from the readme.

Todo

  • Move the DOM-based router to it's own package.
  • Change Acorn's manifest/asset class to handle leading slashes.
  • Figure out a solution to handle images and fonts versioning (attempt a PR into Laravel Mix?)
  • Decide on a solution for changing cache busting from args to filenames (laravel-mix-versionhash or attempt a PR into Laravel Mix).
  • Update documentation for Sage 10.
  • Write a changelog.
  • Bump Add wp_body_open hook (WP 5.2+) #2167 for when 5.2 releases.
  • Sage CLI (probably after release?)

Log1x added 2 commits May 3, 2019 04:15
Add app.name to configuration
Add a ServiceProvider stub
Add missing trailing commas to config
Remove automatic Blade cache removal action as it is no longer necessary
Clean up .gitignore
Clean up JavaScript docblocks
Remove home.js example
Remove leftover Sage 9 information from README
@retlehs retlehs merged commit 29e6dd2 into roots:10.0.0-dev May 3, 2019
@LeoColomb
Copy link
Contributor

  • Figure out a solution to handle images and fonts versioning (attempt a PR into Laravel Mix?)
  • Decide on a solution for changing cache busting from args to filenames (laravel-mix-versionhash or attempt a PR into Laravel Mix).

👍

I have been compiling assets via laraval-mix for years now, even for Sage based projects, and file-versioning is the main drawback.

In both case I would support you opening a PR on the Laraval Mix repo, but the maintainer is difficult to convince for this kind of option.
See:

For standalone images, we can use mix.version([...paths]).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants