960gs support proposition.

[johnraz]

Hello guys,

I did a little bit of work today to try to add support for 960gs.
I found your work was pretty awesome and the only thing that bugged me was the use of blueprint.

In my opinion, neither blueprint nor 960gs is better, it's only a matter of taste.
It would be a shame that people avoid your theme only because of that.

We are using 960gs in our workflow @ work and I had in mind to achieve pretty much what you did with your theme for a while but using 960gs as the grid framework.

So I hope the idea suits you and you'll have some time to review my code. Feel free to tell me if anything needs to be changed or whatever.

Anyway good work so far, keep it up !
John.

[retlehs]

Awesome work John -- this is a great addition and something that I was wanting to get implemented ASAP

Any chance you could also update functions.php so that the $content_width is set based on which grid framework you're using? I believe 960.gs would be 940 instead of the 950 we're setting for Blueprint

Thanks a lot! I'll pull in the request this evening.

[johnraz]

Ben,

I added the clear divs where needed and updated functions.php as you suggested.

I have some other ideas in mind.
Like integrating Firephp and Wp-Alchemy (https://github.com/farinspace/wpalchemy) to ease debug and backend customization ?

Also in the recommended plugins section, I see you make a link to page.ly multiedit, I personally use this one http://wordpress.org/extend/plugins/multiple-content-blocks/.

I like it better because it keeps the original wordpress page edit style. Just a thought.

John.

[swalkinshaw]

Hey John,

I changed it to Page.ly MultiEdit because of a few issues I ran into with Multiple Content Blocks. Specifically, these two:

• http://wordpress.org/support/topic/plugin-multiple-content-blocks-multiple-content-blocks-not-displaying
• http://wordpress.org/support/topic/plugin-multiple-content-blocks-cant-activate-the-blocks-on-a-per-template-basis

I actually had to edit the plugin code to get it to work correctly. I was also annoyed that it wouldn't pick up custom blocks in a slug based template (page-whatever.php) without manually selecting that template. Although I later realized that the Page.ly plugin has the same limitation. I'll probably re-visit that choice though, because you're correct, the Page.ly plugin doesn't work with HTML edit mode.

[retlehs]

thx John

I think we should leave it up to the user to install FirePHP, WP-Alchemy, etc. since not every person is likely to use them. I personally don't develop with Firebug anymore (Chrome Web Development Tools are amazing)

Here's another similar plugin to Alchemy: https://github.com/jaredatch/Custom-Metaboxes-and-Fields-for-WordPress

Feel free to add onto https://github.com/retlehs/roots/wiki/Plugins

I'll be pulling in this request asap, thanks again :)

[johnraz]

@scott : Point taken, I have to admit I usually use the plugin in a standard way (aka with regular page template). So maybe I overlooked some more specific situations. Did you check the latest version though ?

@ben : First, thanks for the word on twitter ;-)

I agree firephp should be kept out of the theme, it's very dependent on the dev's environnement and a quick search on the wp plugin repository returned some plugin to test. So, plugin must be the answer for this one.

I think differently about custom metaboxes, I hardly remember a project where I didn't require it. Wether its wp-alchemy or the link you provided, I still think it's a feature most people would expect.

I'm still unsure about the way to deal with this one (and the same goes for custom post types and custom taxonomies facilities).

Should it be kept out of the framework or embedded for quicker implementation ? What do you think ?

[retlehs]

I agree, it'd good to include one of the metabox plugins. Could you make a new issue for it and we can discuss there? I haven't really looked into WP-Alchemy or Custom Metaboxes and Fields at this point and need to do more research/testing

[jedifunk]

first off, great framework... thanks so much for putting it together.

along the lines of adding 960gs support... any thought of allow for fluid grid layout, such as the outstanding 1140 grid from Andy at cssgrid.net?

having not used your framework yet, i didn't want to dive right in and try to adjust either the 960gs or blueprint to use the 1140 system.

any thoughts?

[retlehs]

thx jedifunk!

i'd love to add 1140 support as well and i think we can get it to work (hopefully without too much work). if you take a look at roots right now, we basically control the #main and #sidebar classes from the theme settings, so [ie.] you should be able to set 'sixcol' for #main and 'threecol' for #sidebar. i'm not sure if more support would be needed, like for the <div class="row"> that appears in 1140

if you're comfortable with php you could download roots and mess with functions.php and the roots-options.php to try and get 1140 in there

i haven't messed around with 1140 yet so i can't give you a definite answer, but will add this to my to-do if no one else gets around to it

[jedifunk]

awesome! i made an end of day feeble attempt at it today, and simply replacing the blueprint grid css with the 1140 did most of the work. there some minor things to need to be sorted out still, but it shouldn't be too hard.

once i get all the css figured out, i'll give the functions a shot, which i don't think will be too hard either.

if anyone else wants to give it a shot as well, please do so.

[johnraz]

Excellent! I was just thinking about responsive design driving my way to work this morning.
I didn't know 1140grid existed, gave it a quick look now and it looks pretty neat.
I'm up to integrate it if it's ok with you guyz, I just need to investigate it to be sure to do the integration correctly.

[retlehs]

go for it! i won't have time for at least a day or two

[jedifunk]

@john
that's great! i've had something come up today, so i doubt i'll have time to dive into. please let us know what you come up with.

[johnraz]

I'm not available tonight but I'll make my best to have something tomorrow for sure ! ;-)

[johnraz]

Quick followup:

I did investigate 1140 grid system more. I started integration, should be able to push something decent to the repo tomorrow.

For now I'll just enjoy the good weather for tonight ;-)

Chill.
John.

[jedifunk]

amazing! i am still hoping to get a chance today, but its slipping away already. i may just wait and see what you put up and see how i can contribute from there.

good lookin out john! look forward to seeing what you push. much respect

bryce