Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add GitHub secret and deploy key to specified --repo #288

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

codepuncher
Copy link
Contributor

Closes #286

I have tested this with specifying: no repo (works as it did before), with an existing repo (works as intended by #286) and with non-existing repo.

For the non-existing repo, gh api returns failed to fetch public key: HTTP 404: Not Found (https://api.github.com/repos/xxx/xxx/actions/secrets/public-key) and is printed to console by existing fmt.Errorf.

@swalkinshaw
Copy link
Member

🎉 looks good! Thank you

@swalkinshaw swalkinshaw merged commit fd32a6e into roots:master Apr 29, 2022
@codepuncher codepuncher deleted the github/issue/286 branch April 29, 2022 23:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: specify owner/repo for key generate
2 participants