Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ditch httr in favour of crul #37

Closed
maelle opened this issue Feb 13, 2018 · 6 comments
Closed

Ditch httr in favour of crul #37

maelle opened this issue Feb 13, 2018 · 6 comments
Assignees

Comments

@maelle
Copy link
Member

maelle commented Feb 13, 2018

I'd like to ditch httr in favour of crul. This way we could use webmockr as well (part of the @sckott -verse)

It wouldn't be too much work since for the simple requests here using crul is no rocket science. I use it in http://github.com/ropensci/ropenaq now and at the time the difficulty was understanding asynchronous requests which we wouldn't need here.

@dpprdan @jesssadler would you be up for learning crul? Otherwise I can do the translation, this doesn't change the design which you both work on.

After opencage next release then an rOpenSci blog post (or 2) about making a package user-friendlier + testing it better would be interesting I think 🤔

@dpprdan
Copy link
Member

dpprdan commented Feb 13, 2018

Apart from your enthusiastic blob post, I don't really know crul? What does it do better than httr (apart from async requests, which is not relevant here)? I'm open to it, but don't see the benefit, yet.

@maelle
Copy link
Member Author

maelle commented Feb 13, 2018

It works with webmockr

@sckott
Copy link

sckott commented Feb 13, 2018

it will also work with vcr very soon to cache http requests for test suites

@dpprdan
Copy link
Member

dpprdan commented Feb 13, 2018

Isn't that what httptest does (as well)? But I don't really know what I am talking about, so, yeah, go ahead. 😄

@maelle
Copy link
Member Author

maelle commented Feb 13, 2018

I do have a bias for rOpenSci tools 😂

@jessesadler
Copy link
Member

I have no real opinion or any expertise in this issue. Trying to learn as much as I can about this stuff, but I am not too far yet. ☺️

@maelle maelle self-assigned this Feb 14, 2018
maelle added a commit that referenced this issue Feb 14, 2018
@maelle maelle closed this as completed Feb 15, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants