Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix opq_osm_id for more than 1 id #282

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

jmaspons
Copy link
Collaborator

Fix #268

Examples on the documentation now works

@mpadge
Copy link
Member

mpadge commented Nov 28, 2022

Thanks @jmaspons, that is indeed what is needed to fix that. Before merging, could you please also update the corresponding tests?

expect_error (
opq_osm_id (type = "node", id = 1:2 + 0.1),
"Only a single id may be entered."
)

That no longer triggers an error, so you could just change expect_error to expect_s3_class, with an expected value of "overpass_query", like the example a couple of tests further. Once that's done, I'll be happy to merge. Thanks!

@mpadge mpadge merged commit 30d65f7 into ropensci:main Nov 28, 2022
@jmaspons jmaspons deleted the fix-opq_osm_id branch November 28, 2022 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Regression (?) in opq_osm_id()
2 participants