Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement adiff queries in opq #291

Merged
merged 7 commits into from
Dec 19, 2022
Merged

Implement adiff queries in opq #291

merged 7 commits into from
Dec 19, 2022

Conversation

jmaspons
Copy link
Collaborator

@jmaspons jmaspons commented Dec 7, 2022

Improves #179

@jmaspons
Copy link
Collaborator Author

jmaspons commented Dec 7, 2022

Test coverage will improve with #285

@mpadge mpadge mentioned this pull request Dec 7, 2022
Closed
6 tasks
@jmaspons
Copy link
Collaborator Author

Rebased and ready for review @mpadge

I changed the order of adiff columns in osmdata_data_frame in order to match the first columns of normal queries, which starts with osm_type and osm_id. With this one, we can close #292

@jmaspons jmaspons mentioned this pull request Dec 17, 2022
Merged
@mpadge mpadge merged commit 286db3e into ropensci:main Dec 19, 2022
@mpadge
Copy link
Member

mpadge commented Dec 19, 2022

Thanks so much @jmaspons for another great contribution!

@jmaspons jmaspons deleted the opq_adiff branch February 2, 2023 10:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaspons @mpadge