Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix queries with !match_case and only one value #317

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Fix queries with !match_case and only one value #317

merged 3 commits into from
Mar 7, 2023

Conversation

jmaspons
Copy link
Collaborator

@jmaspons jmaspons commented Mar 4, 2023

The filter requires a ~ bind operator instead of =

@jmaspons
Fix queries with !match_case and only one value
2d536a8 
The filter requires a ~ bind operator instead of =
@jmaspons jmaspons requested a review from mpadge March 4, 2023 11:11
@jmaspons jmaspons marked this pull request as draft March 4, 2023 11:22
@jmaspons
Fix tests
773d21f 
match_case = FALSE only make sense for regular expressions which are
incompatible with negation of values.

The original qry5 fail in overpass server.
@jmaspons jmaspons marked this pull request as ready for review March 5, 2023 23:46
mpadge
mpadge approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - can you please just update the NEWS with this as a "minor change", and then feel free to merge yourself.

@jmaspons jmaspons merged commit b2fb74e into ropensci:main Mar 7, 2023
@jmaspons jmaspons deleted the fix_oqp_no_matchcase branch March 7, 2023 16:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mpadge mpadge mpadge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaspons @mpadge