Add lat and lon columns for [adiff ... out * center; queries in osmdata_data_frame
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaspons
commented
Mar 11, 2023
mpadge
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
That all looks great. I make the comment somewhere else that it would be good someday to translate this code into C++, but since:
- all loops here are single-level, via
vapply/lapply, and - adiff queries can generally be presumed to be much smaller than "standard" queries
then I think it's still okay for the moment to leave as is. Given which: this is great, thank you!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.