FIX: entrez_post does not use POST method for >200 IDs #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
args$id
is present as input tomake_entrez_query()
(e.g. fromentrez_post
) the IDs are collapsed to a string (length = 1) beforeargs$id length > 200
is used to determine whether to use the POST method. It always uses the GET method because it's always length <= 1.This is a minor change that fixes this issue. It passes your testthat::test() with 4 warnings. May need to be combined with PR #164 if implementing fix for Issue #163.
Reprex - Original code
Created on 2021-08-26 by the reprex package (v2.0.1)
Reprex - After fix
Created on 2021-08-26 by the reprex package (v2.0.1)