Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remarks about the website #193

Closed
maelle opened this issue Jul 25, 2018 · 8 comments
Closed

Remarks about the website #193

maelle opened this issue Jul 25, 2018 · 8 comments
Labels
Milestone

Comments

@maelle
Copy link
Member

maelle commented Jul 25, 2018

Cool that this package has a website!

Am happy to make a PR for these two things if useful.

@sckott
Copy link
Contributor

sckott commented Jul 25, 2018

Thanks!

The vignette title thing is because for some reason it doesn't use the vignette title if the vignette is already built - cause I use prebuilt vignette so they are not run on cran and on pkg installation. not sure how to fix that.

Grouping sounds good, but what do you have in mind?

@maelle
Copy link
Member Author

maelle commented Jul 25, 2018

Not sure exactly but e.g a group for the most useful function(s) (occ), one for the as., one for utils (e.g bbox to wkt)?

@sckott
Copy link
Contributor

sckott commented Jul 25, 2018

sounds good, i guess occ and occ2df for most useful maybe

@maelle
Copy link
Member Author

maelle commented Jul 26, 2018

Should I make a PR?

@sckott
Copy link
Contributor

sckott commented Jul 26, 2018

sounds good

@maelle
Copy link
Member Author

maelle commented Jul 26, 2018

Cool will do in 10 days or so

@maelle
Copy link
Member Author

maelle commented Sep 17, 2018

Nearly two months later, she created the branch 🙈 Sorry for the delay, on it now.

@sckott sckott added the docs label Sep 17, 2018
@sckott sckott added this to the v0.9 milestone Sep 17, 2018
@sckott
Copy link
Contributor

sckott commented Sep 17, 2018

fix via #199

@sckott sckott closed this as completed Sep 17, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants