Website #199
Merged
Website #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also used this PR as an opportunity to add rOpenSci as a funder in DESCRIPTION, with the logo in the pkgdown website. |
|
The Travis build fails but it fails for the master branch too. 🤔 |
|
there's a failing example I'll take care of later, and some tests that often fail only on travis that I haven't figured out yet |
|
thanks @maelle |
sckott
approved these changes
Sep 17, 2018
This was referenced Sep 17, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #193 #197
Not sure the sections are the best, but at least the coercions are at the bottom now.
There's a "queries" tag for
spocc_objectsbut I had to insert its name in the config file as well, not sure why, wasn't able to reproduce this bug on a minimal package. Note that in the current version of the website,spocc_objectsis absent from the reference index see https://ropensci.github.io/spocc/reference/index.html (but https://ropensci.github.io/spocc/reference/spocc_objects.html exists!)