Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

eol traitbank updated to reflect current API results #80

Merged
merged 1 commit into from
Jan 3, 2017

Conversation

dschlaep
Copy link
Contributor

@dschlaep dschlaep commented Jan 3, 2017

  • addresses issue traitbank() not working for me #79

  • function trait_bank:

    • checks for correct structure of returned object
    • prints message if structure mismatches expectation
    • always returns same object structure (potentially with empty
      elements)
  • unit tests:

    • function check_traitbank
    • file 'test-traitbank.R'
  • this pull-request passes unit tests and is installable:

devtools::test()

Loading traits
Testing traits
BETYdb tests: ....................
eol's traitbank tests: .....................

DONE ============================================

devtools::install()

Installing traits
[...]

  • installing source package ‘traits’ ...
    ** R
    ** data
    *** moving datasets to lazyload DB
    ** inst
    ** tests
    ** preparing package for lazy loading
    ** help
    *** installing help indices
    ** building package indices
    ** installing vignettes
    ** testing if installed package can be loaded
  • DONE (traits)
    Reloading installed traits

- function ‘trait bank’:
    * checks for correct structure of returned object
    * prints message if structure mismatches expectation
    * always returns same object structure (potentially with empty
elements)

- unit tests:
    * function ‘check_traitbank’
    * file ‘test-traitbank.R’
@codecov-io
Copy link

Current coverage is 10.58% (diff: 0.00%)

Merging #80 into master will increase coverage by 0.77%

@@            master        #80   diff @@
=========================================
  Files           14         14          
  Lines          683        680     -3   
  Methods          0          0          
  Messages         0          0          
  Branches         0          0          
=========================================
+ Hits            67         72     +5   
+ Misses         616        608     -8   
  Partials         0          0          

Powered by Codecov. Last update 81ace30...1a9f694

@sckott
Copy link
Contributor

sckott commented Jan 3, 2017

thanks for the PR @dschlaep having a look

@sckott
Copy link
Contributor

sckott commented Jan 3, 2017

thanks, LGTM !

@sckott sckott merged commit edf11ff into ropensci:master Jan 3, 2017
@sckott sckott added this to the v0.3 milestone Mar 21, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants