Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI] Add jazzy and other minor updates #1114

Merged
merged 12 commits into from
May 8, 2024
Merged

[CI] Add jazzy and other minor updates #1114

merged 12 commits into from
May 8, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 29, 2024

  • Add Jazzy workflows (I decided to create dedicated files, because it easier to maintain if we branch for jazzy)
  • Add filters to run the ROS - workflows only if code has changed, and the doc workflow only if docs have changed. (branches+path filter have to match both to run the workflow)
  • Check Docs - workflow now uses the correct branch of control.ros.org (not every page is available on every distro any more).
  • Run pre-commit auto-update only once per month

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Apr 29, 2024
@fmauch
Copy link
Contributor

fmauch commented May 7, 2024

Also, I was wondering, why the check_docs workflows didn't have any path restrictions, now I am wondering even more while reviewing ros-controls/ros2_control#1521

@christophfroehlich christophfroehlich requested a review from fmauch May 8, 2024 09:16
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the work @christophfroehlich

The failing CI seems unrelated.

@christophfroehlich christophfroehlich merged commit 4ae8daf into master May 8, 2024
7 of 20 checks passed
@christophfroehlich christophfroehlich deleted the ci_jazzy branch May 8, 2024 11:35
mergify bot pushed a commit that referenced this pull request May 8, 2024
* Add file type filters

* Add jazzy workflows and readme

* Check docs on correct branch

* Specify workflow names

* Run auto-update only once per month

* Update upstream pre-commit wf

---------

Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
(cherry picked from commit 4ae8daf)

# Conflicts:
#	.github/workflows/iron-abi-compatibility.yml
#	.github/workflows/rolling-check-docs.yml
mergify bot pushed a commit that referenced this pull request May 8, 2024
* Add file type filters

* Add jazzy workflows and readme

* Check docs on correct branch

* Specify workflow names

* Run auto-update only once per month

* Update upstream pre-commit wf

---------

Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
(cherry picked from commit 4ae8daf)

# Conflicts:
#	.github/workflows/humble-abi-compatibility.yml
christophfroehlich added a commit that referenced this pull request May 8, 2024
* Add file type filters

* Add jazzy workflows and readme

* Check docs on correct branch

* Specify workflow names

* Run auto-update only once per month

* Update upstream pre-commit wf

---------

Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
(cherry picked from commit 4ae8daf)

# Conflicts:
#	.github/workflows/humble-abi-compatibility.yml

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request May 8, 2024
* Add file type filters

* Add jazzy workflows and readme

* Check docs on correct branch

* Specify workflow names

* Run auto-update only once per month

* Update upstream pre-commit wf

---------

Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
(cherry picked from commit 4ae8daf)

# Conflicts:
#	.github/workflows/iron-abi-compatibility.yml
#	.github/workflows/rolling-check-docs.yml

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants