-
Notifications
You must be signed in to change notification settings - Fork 363
Update API of PID class #1437
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Update API of PID class #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1437 +/- ##
==========================================
- Coverage 84.58% 84.58% -0.01%
==========================================
Files 123 123
Lines 11366 11365 -1
Branches 955 955
==========================================
- Hits 9614 9613 -1
Misses 1449 1449
Partials 303 303
Flags with carried forward coverage won't be shown. Click here to find out more.
|
53 tasks
saikishor
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
(cherry picked from commit c9ca6f7) # Conflicts: # joint_trajectory_controller/src/joint_trajectory_controller.cpp
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros-controls/control_toolbox#246