Skip to content

Update API of PID class #1437

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Update API of PID class #1437

merged 5 commits into from
Feb 13, 2025

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 21, 2024
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (cf8b96e) to head (e7b3078).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pid_controller/src/pid_controller.cpp 25.00% 2 Missing and 1 partial ⚠️
...gripper_controllers/hardware_interface_adapter.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1437      +/-   ##
==========================================
- Coverage   84.58%   84.58%   -0.01%     
==========================================
  Files         123      123              
  Lines       11366    11365       -1     
  Branches      955      955              
==========================================
- Hits         9614     9613       -1     
  Misses       1449     1449              
  Partials      303      303              
Flag Coverage Δ
unittests 84.58% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 85.19% <100.00%> (-0.03%) ⬇️
...ory_controller/test/test_trajectory_controller.cpp 99.74% <100.00%> (ø)
...gripper_controllers/hardware_interface_adapter.hpp 51.72% <0.00%> (ø)
pid_controller/src/pid_controller.cpp 67.67% <25.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit c9ca6f7 into master Feb 13, 2025
20 of 25 checks passed
@christophfroehlich christophfroehlich deleted the apply_pid_api_changes branch February 13, 2025 17:49
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit c9ca6f7)

# Conflicts:
#	joint_trajectory_controller/src/joint_trajectory_controller.cpp
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants