Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft: Fix deprecation warnings in controllers from recent ros2_control variant changes. #1443

Closed
wants to merge 2 commits into from
Closed

Draft: Fix deprecation warnings in controllers from recent ros2_control variant changes. #1443

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5edb5f4
Fix warnings in diff_drive_controller
kumar-sanjeeev Dec 22, 2024
1044e67
Update set_value() usuage to fix warning in velocity_controllers
kumar-sanjeeev Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update set_value() usuage to fix warning in velocity_controllers
  • Loading branch information
@kumar-sanjeeev
kumar-sanjeeev committed Dec 23, 2024
commit 1044e677eb70ac63c2768c2aae5db3a451e91e35
6 changes: 5 additions & 1 deletion velocity_controllers/src/joint_group_velocity_controller.cpp
View file
Original file line number Diff line number Diff line change
@@ -59,7 +59,11 @@ controller_interface::CallbackReturn JointGroupVelocityController::on_deactivate
// stop all joints
for (auto & command_interface : command_interfaces_)
{
command_interface.set_value(0.0);
if (!command_interface.set_value(0.0))
{
RCLCPP_WARN(get_node()->get_logger(), "Error while setting command_interface value to 0.0");
return CallbackReturn::FAILURE;
}
}

return ret;
Loading