-
Notifications
You must be signed in to change notification settings - Fork 363
Deprecate tf.publish_rate parameter for pose_broadcaster #1614
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
- Coverage 85.17% 85.16% -0.01%
==========================================
Files 126 126
Lines 11906 11907 +1
Branches 998 997 -1
==========================================
Hits 10141 10141
- Misses 1452 1454 +2
+ Partials 313 312 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not change the current behavior, but only give the deprecation warning. I suggest that we leave the update() method as it is, just add the deprecated-TODOs there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll edit the OP though to remove the fixes
tag to make sure it doesn't close the other ticket. We can close that one when it's actually removed
First step towards #473.
I have deprecated the
tf.publish_rate
parameter and added necessary warnings.I have added TODOs wherever needed for whenever Jazzy is branched off.