Skip to content

Deprecate tf.publish_rate parameter for pose_broadcaster #1614

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Apr 10, 2025

Conversation

Amronos
Copy link
Contributor

@Amronos Amronos commented Mar 28, 2025

First step towards #473.

I have deprecated the tf.publish_rate parameter and added necessary warnings.
I have added TODOs wherever needed for whenever Jazzy is branched off.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (d1349e1) to head (d51d56c).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pose_broadcaster/src/pose_broadcaster.cpp 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1614      +/-   ##
==========================================
- Coverage   85.17%   85.16%   -0.01%     
==========================================
  Files         126      126              
  Lines       11906    11907       +1     
  Branches      998      997       -1     
==========================================
  Hits        10141    10141              
- Misses       1452     1454       +2     
+ Partials      313      312       -1     
Flag Coverage Δ
unittests 85.16% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pose_broadcaster/src/pose_broadcaster.cpp 82.02% <25.00%> (-2.87%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change the current behavior, but only give the deprecation warning. I suggest that we leave the update() method as it is, just add the deprecated-TODOs there.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll edit the OP though to remove the fixes tag to make sure it doesn't close the other ticket. We can close that one when it's actually removed

@bmagyar bmagyar merged commit 7c6a938 into ros-controls:master Apr 10, 2025
22 of 27 checks passed
@Amronos Amronos deleted the fix-473 branch April 11, 2025 01:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants