Skip to content

[diff_drive] Remove unused parameter and add simple validation #abi-breaking #958

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 31, 2023

  • Remove unused parameter wheels_per_side
  • Update description of names parameters (looking for joint names, not link names).
  • add simple validation to names parameters, this needs some rework of the tests
  • let the load_diff_drive test use the yaml from the test file (which had two bugs)

This breaks ABI because of the class variable change, is this a bad idea to backport?

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d915497) 47.43% compared to head (364d3c5) 47.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
+ Coverage   47.43%   47.47%   +0.03%     
==========================================
  Files          41       41              
  Lines        3862     3859       -3     
  Branches     1816     1814       -2     
==========================================
  Hits         1832     1832              
+ Misses        769      767       -2     
+ Partials     1261     1260       -1     
Flag Coverage Δ
unittests 47.47% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 42.85% <100.00%> (+0.45%) ⬆️

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@bmagyar
Copy link
Member

bmagyar commented Jan 31, 2024

I think we should backport to Iron. Let's leave Humble as-is

@bmagyar bmagyar removed the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jan 31, 2024
@bmagyar bmagyar changed the title [diff_drive] Remove unused parameter and add simple validation [diff_drive] Remove unused parameter and add simple validation #abi-breaking Jan 31, 2024
@bmagyar bmagyar merged commit 2705ca8 into ros-controls:master Jan 31, 2024
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
…reaking (#958)

(cherry picked from commit 2705ca8)

# Conflicts:
#	diff_drive_controller/test/test_diff_drive_controller.cpp
@christophfroehlich christophfroehlich deleted the diff_drive_update branch January 31, 2024 21:46
pac48 pushed a commit to pac48/ros2_controllers that referenced this pull request Feb 2, 2024
bmagyar pushed a commit that referenced this pull request Mar 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants