Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix get_view_key for meta-packages #535

Merged
merged 3 commits into from
Aug 4, 2017
Merged

fix get_view_key for meta-packages #535

merged 3 commits into from
Aug 4, 2017

Conversation

mathias-luedtke
Copy link
Contributor

fixes #534

Should the stack keys get cached as well?

@mathias-luedtke
Copy link
Contributor Author

Should get_loadable_views return meta-packages?

@mathias-luedtke
Copy link
Contributor Author

in the last commit I have unified the handling of catkin packages. Feel free to drop it if you don't want to include this.

@k-okada
Copy link
Contributor

k-okada commented Aug 2, 2017

great!!!, I found this solves our problem reporeted at #536

@mathias-luedtke
Copy link
Contributor Author

@tfoote, @wjwwood: Do you have time to review and release it?
This bug is affecting the CI jobs of many repositories, given they contain meta-packages.

@wjwwood
Copy link
Contributor

wjwwood commented Aug 3, 2017

@ipa-mdl yup, I plan to do it today. Just juggling a few things at the moment.

@wjwwood
Copy link
Contributor

wjwwood commented Aug 4, 2017

@ipa-mdl I was really hoping to update the tests introduced into #531 to cover this case before merging this, but given the priority I think I'll go ahead and merge/release having tested it locally.

If you have time to extend those tests I would really appreciate it. It would help us avoid this in the future.

@wjwwood wjwwood merged commit ec060d0 into ros-infrastructure:master Aug 4, 2017
@mathias-luedtke
Copy link
Contributor Author

Our CI tests are green again :D

If you have time to extend those tests I would really appreciate it. It would help us avoid this in the future.

I will try to.
At least a test for get_view_key should be added.
It would be great to extend the CLI tests in test_rosdep_main.py

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.11.7 breaks rosdep for meta-packages
3 participants