-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix get_view_key for meta-packages #535
fix get_view_key for meta-packages #535
Conversation
Should |
in the last commit I have unified the handling of catkin packages. Feel free to drop it if you don't want to include this. |
great!!!, I found this solves our problem reporeted at #536 |
@ipa-mdl yup, I plan to do it today. Just juggling a few things at the moment. |
@ipa-mdl I was really hoping to update the tests introduced into #531 to cover this case before merging this, but given the priority I think I'll go ahead and merge/release having tested it locally. If you have time to extend those tests I would really appreciate it. It would help us avoid this in the future. |
Our CI tests are green again :D
I will try to. |
fixes #534
Should the stack keys get cached as well?