Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add dependency to sudo #680

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Add dependency to sudo #680

merged 1 commit into from
Sep 18, 2019

Conversation

yotabits
Copy link
Contributor

Having sudo installed is mandatory to run rosdep properly.

Having sudo installed is mandatory to run rosdep properly.
@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files          32       32           
  Lines        2967     2967           
=======================================
  Hits         2239     2239           
  Misses        728      728

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c61b918...46546f4. Read the comment docs.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although not technically necessary as it could be used as root. I think this is good to add as it is necessary for all of our recommended usages as non-root.

@yotabits
Copy link
Contributor Author

Although not technically necessary as it could be used as root. I think this is good to add as it is necessary for all of our recommended usages as non-root.

Also when deploying in docker it allows to not to have to install sudo manually prior to any rosdep call :)

@nuclearsandwich nuclearsandwich merged commit 1dc9266 into ros-infrastructure:master Sep 18, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants