Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use tool-specific user-agent to retrieve custom rules from websites #775

Merged

Conversation

markpaters
Copy link
Contributor

Fixes: #774
gitlab.com (and possibly other sites) reject urlopen() requests from the default user-agent used by urllib2. This PR adds a tool-specific user-agent in the request header for http and https when retrieving custom rules files.
With thanks to Christophe Bedard, who correctly identified the problem.

@markpaters markpaters force-pushed the non-default-user-agent branch from 0aa4687 to c98e27d Compare August 18, 2020 21:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #775 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   74.84%   74.86%   +0.01%     
==========================================
  Files          41       41              
  Lines        3220     3226       +6     
==========================================
+ Hits         2410     2415       +5     
- Misses        810      811       +1     
Impacted Files Coverage Δ
src/rosdep2/sources_list.py 86.58% <85.71%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2667916...c98e27d. Read the comment docs.

@markpaters
Copy link
Contributor Author

This is a very small change. I'd much appreciate it if someone were willing to review it.

@nuclearsandwich nuclearsandwich merged commit 3b747d7 into ros-infrastructure:master Nov 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rosdep cannot fetch https custom rules
4 participants