Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use unittest.mock where possible #850

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Use unittest.mock where possible #850

merged 1 commit into from
Jan 26, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jan 23, 2022

The 'unittest.mock' module has been present since Python 3.3, and some platforms are now dropping the 'mock' backport package.

The 'unittest.mock' module has been present since Python 3.3, and some
platforms are now dropping the 'mock' backport package.
@cottsay cottsay self-assigned this Jan 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #850 (1f224f6) into master (45290f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files          42       42           
  Lines        3317     3317           
=======================================
  Hits         2488     2488           
  Misses        829      829           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45290f4...1f224f6. Read the comment docs.

@nuclearsandwich
Copy link
Contributor

In the spirit of the stairwell. Does it make sense to drop mock from the CI installation since all our tested platforms provide unittest.mock?

@cottsay
Copy link
Member Author

cottsay commented Jan 26, 2022

Does it make sense to drop mock from the CI installation

From an offline discussion: Eventually, but it is still needed for Python 2.7, so it will need to be made conditional for now. I'll make that change in a follow-up PR.

@cottsay cottsay merged commit cde13aa into master Jan 26, 2022
@cottsay cottsay deleted the cottsay/mock branch January 26, 2022 18:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants