Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Melodic qt_metapackages cannot be generated #184

Closed
andre-rosa opened this issue May 2, 2019 · 0 comments · Fixed by #185
Closed

Melodic qt_metapackages cannot be generated #184

andre-rosa opened this issue May 2, 2019 · 0 comments · Fixed by #185

Comments

@andre-rosa
Copy link
Contributor

Currently, it fails with !!!! Could not match license "United States Government Purpose". and throws UnknownLicense: bad license

andre-rosa added a commit to lgsvl/superflore that referenced this issue May 2, 2019
  - Fixes ros-infrastructure#184 generating qt_metapackages recipes in Melodic
  - Currently Proprietary and United States Government Purpose licenses
    aren't matched in SuperFlore and it aborts generation of some melodic
    packages like qt_metapackages/libqt_core
    https://github.com/swri-robotics/qt_metapackages/blob/master/libqt_core/package.xml
  - OpenEmbedded has a generic Proprietary license in
    https://github.com/openembedded/openembedded-core/blob/master/meta/files/common-licenses/Proprietary
    that can match https://www.swri.org/proprietary-notice
  - Government Purpose Rights (GPR) is described at
    https://www.disa.mil/About/Legal-and-Regulatory/DataRights-IP/DataRights#3
  - None of these are in https://spdx.org/licenses/ yet
andre-rosa added a commit to lgsvl/superflore that referenced this issue May 3, 2019
  - Fixes ros-infrastructure#184 generating qt_metapackages recipes in Melodic
  - Currently Proprietary and United States Government Purpose licenses
    aren't matched in SuperFlore and it aborts generation of some melodic
    packages like qt_metapackages/libqt_core
    https://github.com/swri-robotics/qt_metapackages/blob/master/libqt_core/package.xml
  - With the patch, license is output as:
    ...
    LICENSE = "United States Government Purpose & SwRI Proprietary"
    LIC_FILES_CHKSUM = "file://package.xml;beginline=11;endline=12;md5=c19aa8973993203f63bc321fff598ee8"
    ...
  - It handles the case where there are more than one consecutive license
    lines in the xml. If there are two or more licenses and they are not
    consecutive, the output is the same as before (same begin/end line).
andre-rosa added a commit to lgsvl/superflore that referenced this issue May 3, 2019
  - Fixes ros-infrastructure#184 generating qt_metapackages recipes in Melodic
  - Currently Proprietary and United States Government Purpose licenses
    aren't matched in SuperFlore and it aborts generation of some melodic
    packages like qt_metapackages/libqt_core
    https://github.com/swri-robotics/qt_metapackages/blob/master/libqt_core/package.xml
  - With the patch, license is output as:
    ...
    LICENSE = "United States Government Purpose & SwRI Proprietary"
    LIC_FILES_CHKSUM = "file://package.xml;beginline=11;endline=11;md5=8e473b26ead33548c945bdaca143a08d"
    ...
allenh1 pushed a commit that referenced this issue May 6, 2019
- Fixes #184 generating qt_metapackages recipes in Melodic
zffgithub pushed a commit to zffgithub/superflore that referenced this issue Apr 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant