Add command line arguments to the PR text. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Also format the command line better.
|
@tfoote I think this point is a significant improvement (and even some reduction of duplicated code). Let me know if there is anything else you see that could improve this! |
tfoote
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
This is a good step forward. I'd like to see it display the urls/repos that it's operating on. Right now it's using the defaults, but how would you know what they are from reviewing the PR? Expanding it out into a nice English language sentence would be nice.
Supreflore XYZ generator begin run on packages [foo, bar baz] from the rosdistro at ABC last commit HASH
To reproduce run the following
[...]
That makes a lot of sense. I'll add this in a follow up PR before we close #119. |
Merged
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Add command line arguments to the PR text. * Create a --pr-comment option to allow a comment to be added to a PR. Also format the command line better. * Mark version updates in the PR in a different way than a new release. * Move file_pr function to utils, as it doesn't need to be duplicated.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress!
connects to #116.