Adding patch file support for Open Embedded. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
current result is allenh1/meta-ros#28 |
|
Note that I don't expect the CI to pass until after #128 is merged (or, rather, after we fix the tests). |
tfoote
reviewed
Feb 5, 2018
superflore/generators/bitbake/run.py
Outdated
| ' %s from ROS distro %s from allenh1\'s fork of Meta-ROS ' + | ||
| 'from commit %s.' % ( | ||
| 'Superflore yocto generator began regeneration of package(s)' | ||
| ' %s from ROS distro %s from allenh1\'s fork of Meta-ROS' |
There was a problem hiding this comment.
This is missing a parameterization based on #128
There was a problem hiding this comment.
Honestly, I think the allenh1 part can be removed.
| if self.patch_files: | ||
| ret += 'SRC_URI += "\\\n' | ||
| ret += ' \\\n'.join(self.patch_files) + '"\n\n' | ||
| if self.name == 'catkin': |
There was a problem hiding this comment.
Can these be integrated into patches?
There was a problem hiding this comment.
In the normal sense, no. I think I could, however, just detect an existing .inc file and include it.
allenh1
force-pushed
the
oe-patch-support
branch
from
aa01f30 to
951e972
Compare
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Adding patch file support for Open Embedded. * Remap distro parameter for bitbake. * Fix commit string. * Use .inc files for catkin FILES appendages instead of hardcoding.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes fies in the
filesdirectory as patches within the generated recipe text.connects to #129