Skip to content

Commit

Permalink
Merge de32f19 into 6f31f68
Browse files Browse the repository at this point in the history
  • Loading branch information
christophebedard authored May 23, 2022
2 parents 6f31f68 + de32f19 commit 85dc98a
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 25 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ jobs:
- uses: ros-tooling/setup-ros@master
with:
required-ros-distributions: ${{ matrix.ros_distribution }}
# TODO remove this once Humble has been officially released
use-ros2-testing: ${{ matrix.ros_distribution == 'humble' }}
- uses: ./
id: test_all_packages_in_repo
name: "Test all packages in single repo, default options"
Expand Down Expand Up @@ -172,9 +170,8 @@ jobs:
ros_distribution: galactic

# Humble Hawksbill (May 2022 - May 2027)
# TODO uncomment once humble is supported by setup-ros-docker
# - docker_image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
# ros_distribution: humble
- docker_image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
ros_distribution: humble

# Rolling Ridley (see REP 2002: https://www.ros.org/reps/rep-2002.html)
- docker_image: rostooling/setup-ros-docker:ubuntu-jammy-ros-rolling-ros-base-latest
Expand Down
40 changes: 20 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ In this case, `action-ros-ci` will rely on `setup-ros` for installing ROS 2 bina
steps:
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: galactic
required-ros-distributions: humble
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
```
#### Building ROS 2 dependencies from source
Expand All @@ -99,8 +99,8 @@ steps:
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
vcs-repo-file-url: https://raw.githubusercontent.com/ros2/ros2/galactic/ros2.repos
target-ros2-distro: humble
vcs-repo-file-url: https://raw.githubusercontent.com/ros2/ros2/humble/ros2.repos
```

### Build with a custom `repos` or `rosinstall` file
Expand All @@ -120,7 +120,7 @@ steps:
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
vcs-repo-file-url: /tmp/deps.repos
```

Expand All @@ -135,11 +135,11 @@ Simply use `target-ros1-distro` instead of `target-ros2-distro`.
steps:
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: melodic
required-ros-distributions: noetic
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros1-distro: melodic
target-ros1-distro: noetic
```

### Skip tests
Expand All @@ -150,11 +150,11 @@ To skip tests and code coverage data processing, set the `skip-tests` option to
steps:
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: galactic
required-ros-distributions: humble
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
skip-tests: true
```

Expand All @@ -167,11 +167,11 @@ This allows using a `colcon` option/argument that is not exposed by this action'
steps:
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: galactic
required-ros-distributions: humble
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
colcon-defaults: |
{
"build": {
Expand All @@ -191,7 +191,7 @@ memory corruption bugs.
steps:
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: galactic
required-ros-distributions: humble
- uses: ros-tooling/action-ros-ci@v0.2
with:
colcon-defaults: |
Expand All @@ -202,7 +202,7 @@ steps:
}
colcon-mixin-repository: https://raw.githubusercontent.com/colcon/colcon-mixin-repository/3e627e0fa30db85aea05a50e2c61a9832664d236/index.yaml
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
```

To look for detected memory errors, check the build logs for entries containing `ERROR: AddressSanitizer`. Example:
Expand All @@ -227,11 +227,11 @@ preferable to use a `colcon` mixin (through [`colcon-defaults`](#Use-a-colcon-de
steps:
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: galactic
required-ros-distributions: humble
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
colcon-defaults: |
{
"build": {
Expand All @@ -252,11 +252,11 @@ Generate code coverage information for Python files using the appropriate mixins
steps:
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: galactic
required-ros-distributions: humble
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
colcon-defaults: |
{
"build": {
Expand All @@ -283,11 +283,11 @@ steps:
- uses: actions/checkout@v2
- uses: ros-tooling/setup-ros@v0.3
with:
required-ros-distributions: galactic
required-ros-distributions: humble
- uses: ros-tooling/action-ros-ci@v0.2
with:
package-name: my_package
target-ros2-distro: galactic
target-ros2-distro: humble
colcon-defaults: |
{
"build": {
Expand Down Expand Up @@ -330,7 +330,7 @@ steps:
id: action_ros_ci_step
with:
package-name: ament_copyright
target-ros2-distro: galactic
target-ros2-distro: humble
- uses: actions/upload-artifact@v1
with:
name: colcon-logs
Expand Down

0 comments on commit 85dc98a

Please # to comment.