Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sync Windows choco dependencies with ROS 2 CI #493

Merged

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented May 28, 2022

Fixes #491

This changes the Windows dependencies installation to more closely match how it is done for ci.ros2.org: https://github.com/ros-infrastructure/ros2-cookbooks/blob/de9d4cc159f2c4402e4636c458ad4bc535d0610d/cookbooks/ros2_windows/recipes/chocolatey_installs.rb

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard added bug Something isn't working enhancement New feature or request labels May 28, 2022
@christophebedard christophebedard requested a review from a team as a code owner May 28, 2022 14:38
@christophebedard christophebedard self-assigned this May 28, 2022
@christophebedard christophebedard requested review from lihui815 and MichaelOrlov and removed request for a team May 28, 2022 14:38
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #493 (f2a93a2) into master (dd88a18) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   92.77%   93.06%   +0.29%     
==========================================
  Files           8        8              
  Lines         166      173       +7     
  Branches       15       16       +1     
==========================================
+ Hits          154      161       +7     
  Misses         12       12              
Impacted Files Coverage Δ
src/package_manager/chocolatey.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd88a18...f2a93a2. Read the comment docs.

@christophebedard
Copy link
Member Author

This is clearly an improvement, so I'll merge.

@christophebedard christophebedard merged commit 90cf87d into master Jun 2, 2022
@christophebedard christophebedard deleted the christophebedard/update-windows-dependencies branch June 2, 2022 18:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows is broken due to cppcheck 2.8 installation by chocolatey
1 participant