Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add pyopenssl to list of pip3 dependencies #516

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

achim-k
Copy link
Contributor

@achim-k achim-k commented Oct 3, 2022

Fixes #515

Unfortunately I did not have time to test this

@achim-k achim-k requested a review from a team as a code owner October 3, 2022 16:56
@achim-k achim-k requested review from emersonknapp and christophebedard and removed request for a team October 3, 2022 16:56
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 93.10% // Head: 93.10% // No change to project coverage 👍

Coverage data is based on head (7f7013b) compared to base (a04c0f0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files           8        8           
  Lines         174      174           
  Branches       16       16           
=======================================
  Hits          162      162           
  Misses         12       12           
Impacted Files Coverage Δ
src/package_manager/pip.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christophebedard
Copy link
Member

Thanks for the PR @achim-k!

It would be great if you could test it (achim-k/setup-ros@patch-1). Note that you'll need to install npm and generate build artifacts (i.e., a JS file) in order for your change to have an effect.

Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
@achim-k
Copy link
Contributor Author

achim-k commented Oct 3, 2022

It would be great if you could test it (achim-k/setup-ros@patch-1). Note that you'll need to install npm and generate build artifacts (i.e., a JS file) in order for your change to have an effect.

Done ✔️
I have added the generated build artifact and squashed the commits into one.

I tested the change in achim-k/rosbridge_suite@b951218 and the job that previously failed succeeds now 👍

@emersonknapp emersonknapp changed the title Add pyopenssl to list of pip3 dependencies, fixes #515. Add pyopenssl to list of pip3 dependencies Oct 3, 2022
@emersonknapp emersonknapp merged commit dde7079 into ros-tooling:master Oct 3, 2022
@achim-k
Copy link
Contributor Author

achim-k commented Oct 4, 2022

@emersonknapp / @christophebedard, would you mind to create a new release now that this PR has been merged?

@christophebedard
Copy link
Member

@achim-k done! https://github.com/ros-tooling/setup-ros/releases/tag/0.4.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip install --upgrade breaks pyopenssl package
3 participants