Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to latest binary ros2 windows distributions #548

Conversation

hoffmann-stefan
Copy link
Contributor

This updates to the latest windows binary distributions like this PR did: #450

Doing this manually since #453 isn't resolved yet.

Came across this when debugging the CI failure for this ros2_dotnet PR: ros2-dotnet/ros2_dotnet#90 (comment)

  • The newest github windows runner images include newer versions of CMake that are not compatible with the version of ament_cmake (0.9.9) that is included in the old binary release specified in setup-ros.
  • Support new target export template introduced with CMake 3.24 ament/ament_cmake#395 is in ament_cmake v0.9.11 that should be included in the newest foxy binary release.
  • Tested this by using my feature branch as temporary commit in my ros2_dotnet PR, though there only foxy is used currently.

Signed-off-by: Stefan Hoffmann <stefan.hoffmann@schiller.de>
@emersonknapp emersonknapp enabled auto-merge (squash) March 8, 2023 17:04
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (163cec9) 93.18% compared to head (bb6a879) 93.18%.

❗ Current head bb6a879 differs from pull request most recent head aada801. Consider uploading reports for the commit aada801 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files           8        8           
  Lines         176      176           
  Branches       17       17           
=======================================
  Hits          164      164           
  Misses         12       12           
Impacted Files Coverage Δ
src/setup-ros-windows.ts 78.12% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@emersonknapp emersonknapp merged commit d0ac946 into ros-tooling:master Mar 8, 2023
@hoffmann-stefan hoffmann-stefan deleted the update-windows-distributions branch March 9, 2023 16:38
@hoffmann-stefan
Copy link
Contributor Author

@emersonknapp: Thanks for the quick merge!

When can we expect an release that includes this update? Is there some process or usual schedule for a release? Did use the merged version of this successfully on this PR, but it would be nice as well to have a tagged version there. But no hurries.

@christophebedard
Copy link
Member

We just create new releases as needed. I'll create 0.6.1 now.

@christophebedard
Copy link
Member

We just create new releases as needed. I'll create 0.6.1 now.

Done! https://github.com/ros-tooling/setup-ros/releases/tag/0.6.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants