Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

battery_dash_widget: Tooltip states name of battery. #21

Merged
merged 1 commit into from
Apr 25, 2013

Conversation

dornhege
Copy link

battery_dash_widget: float values are rounded.

battery_dash_widget: float values are rounded.
@ghost ghost assigned 130s Apr 16, 2013
@130s
Copy link
Member

130s commented Apr 16, 2013

It'll be the middle of next week when I'll be able to test with robots. I still can test if there are any simulations available. Any idea?

@dornhege
Copy link
Author

As that uses diagnostics or similar I don't think that's simulated anywhere (besides sending manual messages). I also tested it by just switching on the robot.

130s pushed a commit that referenced this pull request Apr 25, 2013
I confirmed that the proposed part (to avoid float value rounded) works, by unit test file I'll upload later.

I haven't been able to test With real robots -- I only have an access to `PR2`, of which dashboard overrides `BatteryDashWidget`.`update_time` method.
@130s 130s merged commit dac975e into ros-visualization:groovy-devel Apr 25, 2013
@130s
Copy link
Member

130s commented Apr 25, 2013

A simple unit test is uploaded via 342ffe7

dirk-thomas pushed a commit to ros-visualization/rqt_robot_dashboard that referenced this pull request Apr 25, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants