add fast-float to rosdep #44354
add fast-float to rosdep #44354
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xmlfile must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Discord Server and ask questions in the
#infra-helpchannel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.
For changes related to rosdep:
- 📝 There are problems with the names of new rosdep keys:
- New key names should typically match the Ubuntu package name
- ✅ Platforms for new rosdep rules are valid
- ✅ Installers for new rosdep rules are valid
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
| @@ -1041,6 +1041,17 @@ fakeroot: | |||
| nixos: [fakeroot] | |||
| rhel: [fakeroot] | |||
| ubuntu: [fakeroot] | |||
| fast-float: | |||
There was a problem hiding this comment.
This key does not match the Ubuntu package name
There was a problem hiding this comment.
In general, we prefer that rosdep key names match the corresponding Ubuntu package name where possible:
| fast-float: | |
| libfast-float-dev: |
Reminder that you'll need to move the stanza after renaming to maintain alphabetical order.
|
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
github-actions
bot
added
the
stale
| @@ -1041,6 +1041,17 @@ fakeroot: | |||
| nixos: [fakeroot] | |||
| rhel: [fakeroot] | |||
| ubuntu: [fakeroot] | |||
| fast-float: | |||
There was a problem hiding this comment.
In general, we prefer that rosdep key names match the corresponding Ubuntu package name where possible:
| fast-float: | |
| libfast-float-dev: |
Reminder that you'll need to move the stanza after renaming to maintain alphabetical order.
| osx: | ||
| homebrew: | ||
| packages: [fast_float] | ||
| opensuse: [fast_float] |
There was a problem hiding this comment.
The openSUSE package listed couldn't be found by the automation, as it appears from the dashboard that the package is only available in openSUSE Tumbleweed. The rule for openSUSE should be omitted until it is available in a supported release.
| opensuse: [fast_float] |
| homebrew: | ||
| packages: [fast_float] | ||
| opensuse: [fast_float] | ||
| ubuntu: [libfast-float-dev] |
There was a problem hiding this comment.
This package is only available on Noble and newer. Our tooling performs differently when a package has no mapping and when a package can't be found, and the latter is regarded as an error in the rosdep database. We should explicitly state that the package is not expected to exist for older but supported versions of Ubuntu.
| ubuntu: [libfast-float-dev] | |
| ubuntu: | |
| '*': [libfast-float-dev] | |
| focal: null | |
| jammy: null |
cottsay
removed
the
stale
Please add the following dependency to the rosdep database.
Package name:
fast_float
Package Upstream Source:
TODO link to source repository
Purpose of using this:
Used as a dependency in c++ libraries such as folly
Distro packaging links:
Links to Distribution Packages