Skip to content

Domain id init #223

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Domain id init #223

wants to merge 29 commits into from

Conversation

DS3a
Copy link
Contributor

@DS3a DS3a commented Jul 10, 2022

I've added the a ContextBuilder which I am using in new() in context.rs please review this so that I can proceed to adding domain_id options by overrloading these functions using ros_distro cfg attributes

DS3a and others added 29 commits June 14, 2022 15:30
@DS3a
add time.rs to src as well as to lib.rs (ros2-rust#121)
8e9393d
@DS3a
added the Time struct
efe7010
@DS3a
add duration.rs to lib and src
f024ad6
@DS3a
added the Duration struct
92e55a1
@DS3a
complete duration.rs
c332adb
@DS3a
add function to return Duration object
68d6df6
@DS3a
implemented clone for Duration
7eceafe
@DS3a
changes made to time.rs and lib.rs
9c29dee
@DS3a
Merge branch 'ros2-rust:main' into main
dc66c3c
@DS3a
implement Add for time.rs
7f9a6a7
@DS3a
add max implementation for Duration
15c9914
@DS3a
complete time.rs
49fe3ed
@DS3a
add clock.rs to src and lib.rs
607a201
@DS3a
adjusted duration.rs to accomodate negative values as well
a0d288b
@DS3a
refactor time.rs
4260124
@DS3a
add initial functionality to clock.rs
bd356cb
@DS3a
add todos to finish after review
0fce763
@DS3a
made get_lock publich
48a5543
@DS3a
added now to clock.rs
7853af4
@DS3a
refined duration.rs
c432746
@DS3a
implement ord and eq for Tie
3a9d90c
@DS3a
added some more functions
e5c194d
@DS3a
Merge branch 'ros2-rust:main' into main
6920fda
@DS3a
adding ContextBuildr
4dc0d00
@DS3a
Merge branch 'ros2-rust:main' into main
c35dbfd
@DS3a
Merge branch 'main' of github.com:DS3a/ros2_rust into domain_id_init
dc17ed9
@DS3a
implemented new in context/builder.rs
7adb4f6
@DS3a
add context builder (ros2-rust#206)
3f0360f
@DS3a
remove unwanted dependencies
2f69b60
@mxgrey
Copy link
Collaborator

mxgrey commented Mar 10, 2025

I think the purpose of this PR is covered by InitOptions which was introduced in #386

It should be reasonable to close this PR at this point.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DS3a @mxgrey