Skip to content

Drop support for float128. #788

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

Drop support for float128. #788

merged 1 commit into from
Nov 20, 2024

Conversation

clalancette
Copy link
Contributor

See ros2/rosidl_dynamic_typesupport#11 for a description on why we want to do this.

@clalancette
Drop support for float128.
297a3b5 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

Pulls: #788
Gist: https://gist.githubusercontent.com/clalancette/ab873bae699fa71d0ffb66e5a0179afc/raw/40cf3cc65e95b3cc0577805c2dd1f134a3428977/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14842

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@ahcorde
Copy link
Contributor

ahcorde commented Nov 20, 2024

Relaunch Windows:

  • Windows Build Status

@clalancette clalancette merged commit 417c54e into rolling Nov 20, 2024
3 checks passed
@clalancette clalancette deleted the clalancette/drop-float128 branch November 20, 2024 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs

@sloretz sloretz Awaiting requested review from sloretz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clalancette @ahcorde @MiguelCompany @fujitatomoya